Skip to content

Conversation

@filintod
Copy link
Contributor

@filintod filintod commented Sep 4, 2025

Description

Cherry Pick for #822

@elena-kolevska

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

* initial

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* fixes after proto change upstream

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* minor name changes and cleanup unused function

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* refactors, updates to readme, linting

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* feedback

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* feedback, updates

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* fix import in examples

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* cleanup, import, lint, more conversation helpers

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* clarify README, minor test import changes, copyright

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* feedback DRY test_conversation file

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* lint

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* move conversation classes in _response module to conversation module.

Some example README refactor/lint

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* minor readme change

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* Update daprdocs/content/en/python-sdk-docs/python-client.md

Co-authored-by: Albert Callarisa <albert@acroca.com>
Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* lint

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* updates to fix issue with tool calling helper when dealing with classes instead of dataclasses, and also with serializatin output of the tool back to the LLM

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* coalesce conv helper tests, fix typing lint

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* make indent line method doc more dev friendly

Co-authored-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* tackle some feedback, still missing unit tests

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* add unit test to convert_value_to_struct

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* more unit tests per feedback

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* make async version of unit test conversation

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* add some information how to run markdown tests with a different runtime

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* ran tox -e ruff, even though tox -e flake8 was fine

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* add tests to increase coverage in conversation and conversation_helpers that codecov pointed out

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* add more information on execute registered tools, also added more tests for them to validate

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* fix test failing on py 1.13. Merge two unit test files per feedback

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* Linter

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* fix typing issue with UnionType in py3.9

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

---------

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Co-authored-by: Albert Callarisa <albert@acroca.com>
Co-authored-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Co-authored-by: Elena Kolevska <elena@kolevska.com>
@filintod filintod requested review from a team as code owners September 4, 2025 19:49
@codecov
Copy link

codecov bot commented Sep 7, 2025

Codecov Report

❌ Patch coverage is 91.83246% with 78 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-1.16@efd34f8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
dapr/clients/grpc/_conversation_helpers.py 85.29% 75 Missing ⚠️
dapr/clients/grpc/conversation.py 99.03% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.16     #832   +/-   ##
===============================================
  Coverage                ?   87.33%           
===============================================
  Files                   ?       93           
  Lines                   ?     6143           
  Branches                ?        0           
===============================================
  Hits                    ?     5365           
  Misses                  ?      778           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elena-kolevska elena-kolevska merged commit d62dd5e into dapr:release-1.16 Sep 7, 2025
15 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2025
* 1.16.0-rc1

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* [Conversation API - Alpha2] Add new tool calling capability (#822) (#832)

* initial



* fixes after proto change upstream



* minor name changes and cleanup unused function



* refactors, updates to readme, linting



* feedback



* feedback, updates



* fix import in examples



* cleanup, import, lint, more conversation helpers



* clarify README, minor test import changes, copyright



* feedback DRY test_conversation file



* lint



* move conversation classes in _response module to conversation module.

Some example README refactor/lint



* minor readme change



* Update daprdocs/content/en/python-sdk-docs/python-client.md




* lint



* updates to fix issue with tool calling helper when dealing with classes instead of dataclasses, and also with serializatin output of the tool back to the LLM



* coalesce conv helper tests, fix typing lint



* make indent line method doc more dev friendly




* tackle some feedback, still missing unit tests



* add unit test to convert_value_to_struct



* more unit tests per feedback



* make async version of unit test conversation



* add some information how to run markdown tests with a different runtime



* ran tox -e ruff, even though tox -e flake8 was fine



* add tests to increase coverage in conversation and conversation_helpers that codecov pointed out



* add more information on execute registered tools, also added more tests for them to validate



* fix test failing on py 1.13. Merge two unit test files per feedback



* Linter



* fix typing issue with UnionType in py3.9



---------

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Co-authored-by: Albert Callarisa <albert@acroca.com>
Co-authored-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Co-authored-by: Elena Kolevska <elena@kolevska.com>

* update docs with tool calling helpers info (#838)

Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>

* 1.16.0rc2

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* use latest durabletask (#840)

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* 1.16.0

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Adds support for interceptors and concurrency_options arguments in the workflow engine (#841)

Signed-off-by: Albert Callarisa <albert@diagrid.io>

* Implement multi-app workflows (#844)

* feat: Adds support for cross-app calls.

Signed-off-by: Albert Callarisa <albert@diagrid.io>

* Use durabletask alpha.9

Signed-off-by: Albert Callarisa <albert@diagrid.io>

* Added examples for error scenarios in multi-app workflow

Signed-off-by: Albert Callarisa <albert@diagrid.io>

* Remove unnecessary hardcoded ports

Signed-off-by: Albert Callarisa <albert@diagrid.io>

---------

Signed-off-by: Albert Callarisa <albert@diagrid.io>

* chore: Rename wait_until_ready to wait_for_sidecar (#843)

Signed-off-by: Albert Callarisa <albert@diagrid.io>
Co-authored-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>

* 1.16.1rc1 (#846)

Signed-off-by: Albert Callarisa <albert@diagrid.io>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Co-authored-by: Elena Kolevska <elena@kolevska.com>
Co-authored-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
Co-authored-by: Albert Callarisa <albert@acroca.com>
Co-authored-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Co-authored-by: Albert Callarisa <albert@diagrid.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants