Conversation
…w ups in the zoom in/out).
…arget.getBoundingClientRect()
…eally well on mobile touch devices, good job.
mirabilos
left a comment
There was a problem hiding this comment.
Do you have a recommended procedure to test this? An example page, or just the one on https://dygraphs.com/ and then pinching around, or something better than that?
| } | ||
|
|
||
| if (Math.abs(initHalfHeight) > minAllowed) { | ||
| var damp = 1 / (Math.abs(initHalfHeight) - minAllowed) |
There was a problem hiding this comment.
AFAICT var has function scope, so this is an error. I’d say declare var damp above with the initHalf{Width,Height} and reuse it in both branches.
| // ex is a tuple [a, b], with a <= b | ||
| function isOutOfExtremes(p, ex) { | ||
|
|
||
| return p < ex[0] || p > ex[1] |
There was a problem hiding this comment.
please do add explicit semicola at the end of instructions (not just here but everywhere); semicolon insertion is considered harmful
Try numericnews I am sorry, but 5 years later I do not find much time to give additional support. |
This pull request is an experimentation on improving the UX of pinch-zoom.
It starts from pull request 990, which fixes two functional bugs, and it adds the following: