Drop support for python3.6 #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e4ac54d.
|
By merging this, it would unblock #451, which would in turn make that issue labeled "good first issue" an actual good first issue. It's not a great first issue if it's blocked by paradoxical CI/CD rules. |
Collaborator
Author
|
As much as I would love to merge it, I don't have permissions to do so |
cetanu
approved these changes
Feb 9, 2023
Collaborator
cetanu
left a comment
cetanu
left a comment
There was a problem hiding this comment.
Seems fine, people stuck on 3.6 can use the previous version and it's advisable that they upgrade anyway.
bbonenfant
pushed a commit
to pachyderm/python-betterproto
that referenced
this pull request
Jan 23, 2024
# Conflicts: # poetry.lock
bbonenfant
pushed a commit
to pachyderm/python-betterproto
that referenced
this pull request
Jan 23, 2024
# Conflicts: # poetry.lock # Conflicts: # poetry.lock # pyproject.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.