-
Notifications
You must be signed in to change notification settings - Fork 231
allow override of timeout, deadline and metadata #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
12e2181 to
b8779e1
Compare
Gobot1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea. One qeustion, why is _Metadata exported as a "private" type alias? Could you possible rename it?
Ideally the isort commits would be a separate PR.
|
@Gobot1234 I'd like to keep the isort-ing of the generated code as a separate commit on this PR as we introduce additional imports here. I'll spint out the isort for the betterproto code into another PR. As for |
I could just merge the isort PR first right and keep the commits here and there shouldn't be any conflicts? |
Making _types.py public seems like a good idea to me |
This change ensures that overrides for timeout, deadline and metadata are available as parameters for higher lever methods. Resolves: danielgtaylor#275
|
@Gobot1234 I ended up just making the type definitions public since it did not feel right for exposing grpclib clibe types under |
|
Thank you :) |
This change ensures that overrides for timeout, deadline and metadata
are available as parameters for higher lever methods.
Resolves: #275
In addition to the above fix this PR also includes the following:
run isort on generated code before black formattingcompiler: run isort on compiled code #355add isort pre-commit hook and initial configuration for betterproto codebase.pre-commit: add isort hook and apply #354