Skip to content

Conversation

@abn
Copy link
Collaborator

@abn abn commented Mar 11, 2022

This change ensures that overrides for timeout, deadline and metadata
are available as parameters for higher lever methods.

Resolves: #275

In addition to the above fix this PR also includes the following:

@abn abn marked this pull request as ready for review March 11, 2022 19:51
@abn abn force-pushed the issue/275 branch 2 times, most recently from 12e2181 to b8779e1 Compare March 11, 2022 20:08
Copy link
Collaborator

@Gobot1234 Gobot1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. One qeustion, why is _Metadata exported as a "private" type alias? Could you possible rename it?
Ideally the isort commits would be a separate PR.

@abn
Copy link
Collaborator Author

abn commented Mar 12, 2022

@Gobot1234 I'd like to keep the isort-ing of the generated code as a separate commit on this PR as we introduce additional imports here. I'll spint out the isort for the betterproto code into another PR.

As for _Metadata I am reusing what was already there, seems like it is a copy of the one one from grpclib. One option would be to move it to types.py and make it non-private. I can do that change with this or later as a separate change.

@Gobot1234
Copy link
Collaborator

@Gobot1234 I'd like to keep the isort-ing of the generated code as a separate commit on this PR as we introduce additional imports here. I'll spint out the isort for the betterproto code into another PR.

I could just merge the isort PR first right and keep the commits here and there shouldn't be any conflicts?

@Gobot1234
Copy link
Collaborator

As for _Metadata I am reusing what was already there, seems like it is a copy of the one one from grpclib. One option would be to move it to types.py and make it non-private. I can do that change with this or later as a separate change.

Making _types.py public seems like a good idea to me

abn added 2 commits March 13, 2022 01:56
This change ensures that overrides for timeout, deadline and metadata
are available as parameters for higher lever methods.

Resolves: danielgtaylor#275
@abn
Copy link
Collaborator Author

abn commented Mar 13, 2022

@Gobot1234 I ended up just making the type definitions public since it did not feel right for exposing grpclib clibe types under betterproto.types.

@Gobot1234 Gobot1234 merged commit 18a518e into danielgtaylor:master Mar 13, 2022
@Gobot1234
Copy link
Collaborator

Thank you :)

@abn abn deleted the issue/275 branch March 13, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Templated client service methods don't allow for pass-through of metadata

3 participants