fix: SECURITY_CONTEXT renders empty strings on filter with enabled Tesseract#10576
Open
paveltiunov wants to merge 8 commits intomasterfrom
Open
fix: SECURITY_CONTEXT renders empty strings on filter with enabled Tesseract#10576paveltiunov wants to merge 8 commits intomasterfrom
paveltiunov wants to merge 8 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10576 +/- ##
==========================================
- Coverage 83.40% 78.57% -4.84%
==========================================
Files 250 475 +225
Lines 75196 92873 +17677
Branches 0 3634 +3634
==========================================
+ Hits 62718 72971 +10253
- Misses 12478 19357 +6879
- Partials 0 545 +545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@paveltiunov can you clarify what this is fixing? The title is a little scary sounding :) I'm looking to enable Tesseract to leverage multi-stage calculations. |
Member
Author
|
@hank-sq Great catch! It isn't security issue here. Didn't mean to scare anyone. It's just failing if you'll try to call filter with enabled tesseract. So queries won't execute in the worst case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List