Skip to content

fix: SECURITY_CONTEXT renders empty strings on filter with enabled Tesseract#10576

Open
paveltiunov wants to merge 8 commits intomasterfrom
fix-tesseract-security-context
Open

fix: SECURITY_CONTEXT renders empty strings on filter with enabled Tesseract#10576
paveltiunov wants to merge 8 commits intomasterfrom
fix-tesseract-security-context

Conversation

@paveltiunov
Copy link
Copy Markdown
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner March 30, 2026 02:35
@github-actions github-actions bot added rust Pull requests that update Rust code javascript Pull requests that update Javascript code labels Mar 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 43.54839% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.57%. Comparing base (ef1ab6d) to head (ac921a7).
⚠️ Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
.../compiler/transpilers/CubePropContextTranspiler.ts 3.57% 27 Missing ⚠️
...cubejs-schema-compiler/src/compiler/CubeSymbols.ts 76.47% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10576      +/-   ##
==========================================
- Coverage   83.40%   78.57%   -4.84%     
==========================================
  Files         250      475     +225     
  Lines       75196    92873   +17677     
  Branches        0     3634    +3634     
==========================================
+ Hits        62718    72971   +10253     
- Misses      12478    19357    +6879     
- Partials        0      545     +545     
Flag Coverage Δ
cube-backend 57.87% <43.54%> (?)
cubesql 83.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paveltiunov paveltiunov requested a review from a team as a code owner March 31, 2026 23:19
@hank-sq
Copy link
Copy Markdown
Contributor

hank-sq commented Apr 1, 2026

@paveltiunov can you clarify what this is fixing? The title is a little scary sounding :)

I'm looking to enable Tesseract to leverage multi-stage calculations.

@paveltiunov paveltiunov changed the title fix: SECURITY_CONTEXT is not working correctly with enabled Tesseract fix: SECURITY_CONTEXT renders empty strings on filter with enabled Tesseract Apr 2, 2026
@paveltiunov
Copy link
Copy Markdown
Member Author

@hank-sq Great catch! It isn't security issue here. Didn't mean to scare anyone. It's just failing if you'll try to call filter with enabled tesseract. So queries won't execute in the worst case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants