Timedelta fill value #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-moth
force-pushed
the
timedelta-fill-value
branch
from
27d7d53 to
42ecdc2
Compare
Depending on the variable type, the masked value will be one of:
* np.nan - for floats
* np.nan + j * np.nan - for complex numbers
* np.datetime64('nat') - for datetimes
* np.timedelta64('nat') - for timedeltas
The change makes emsarray use `xarray.core.dtypes.maybe_promote` to
determine the correct mask value, preventing similar future issues if
the fill value rules in xarray change.
mx-moth
force-pushed
the
timedelta-fill-value
branch
from
42ecdc2 to
ba6f6b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for timedelta64 variables and _FillValue / missing_value shenanigans.