Fix license #63
Merged
Fix license #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the source tarball the LICENCE file is correctly included, but somewhere along the way the file is dropped and not included in the wheel. This is not great already, but then the conda-forge package fails to build because there is no LICENSE file. The easiest solution is to spell licence incorrectly. The yanks win this one...
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LICENCE file was not being included in the final wheel, despite all the known fields being filled out. It seems the yanks win this one. Renamed to LICENSE.
This resulted in the wheel not including a licence file at all, and the conda-forge package failing to build because of that.
I have no idea why this worked in 0.3.1 and why it has broken in 0.4.0.