Generate a fan triangulation for convex polygons #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-moth
force-pushed
the
optimise-triangulation
branch
from
02c9ea7 to
da3ebab
Compare
Collaborator
|
When tested with MoVE we saw the following improvements. v0.7.0 time Time elapsed during the process: 4.897634860997641 Time elapsed during the process: 4.988207356000203 Optimised Triangulation time Time elapsed during the process: 1.4324180190014886 Time elapsed during the process: 1.7977412979998917 I haven't noticed any regressions in MoVE, however MoVE was previously using emsarray 0.4.1. |
Contributor
|
I'm getting similar speed ups to David, so for the larger National model data, they go from ~5mins down to 1.5 mins |
The ear clipping method is correct for all polygons, but slow. For convex polygons a fan triangulation is much quicker. Most polygons will be convex. For an example dataset this sped up triangulation on my machine from around 6 seconds to 1 second.
mx-moth
force-pushed
the
optimise-triangulation
branch
from
da3ebab to
c8b9fcb
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ear clipping method is correct for all polygons, but slow. For convex polygons a fan triangulation is much quicker. Most polygons will be convex. For an example dataset this sped up triangulation on my machine from around 6 seconds to 1 second.