Allow to add custom HTML attributes on buttons#298
Open
Florian-B wants to merge 1 commit intocraue:masterfrom
Open
Allow to add custom HTML attributes on buttons#298Florian-B wants to merge 1 commit intocraue:masterfrom
Florian-B wants to merge 1 commit intocraue:masterfrom
Conversation
c440605 to
1931f1b
Compare
1931f1b to
93f2a04
Compare
|
Changes Unknown when pulling c440605 on Florian-B:allow-custom-attr-on-buttons into ** on craue:master**. |
1 similar comment
|
Changes Unknown when pulling c440605 on Florian-B:allow-custom-attr-on-buttons into ** on craue:master**. |
|
Changes Unknown when pulling 93f2a04 on Florian-B:allow-custom-attr-on-buttons into ** on craue:master**. |
|
Changes Unknown when pulling 93f2a04 on Florian-B:allow-custom-attr-on-buttons into ** on craue:master**. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows to add custom attributes on buttons (very useful for tracking or javascript).
Will add
data-foo="bar"attribute for finish button anddata-foo="bar" data-bar="foo"attributes for reset buttonSee: #267