Add ability for window to remember position and size #208
Conversation
nvpy/view.py
Outdated
| try: | ||
| if config.pixel_width: | ||
| sentence = 'MmMmMmMmMmMmMmMmMmMmMmMmMmMmMm' | ||
| text_width = int(float(config.pixel_width)/((float(f.measure(sentence)))*.64)*len(sentence)) |
There was a problem hiding this comment.
@yuuki0xff I really hate this calculation. I had to add the *.64 on my machine to get the pixel width calculated to be anywhere near what the vale is saved to in the file from one time opening the app to the next. If you know a better way to figure out how wide it should be (or how to make the Frame width be what this follows), I'm all for it. That, or take out this try/except, and let the default just be what it is on start.
There was a problem hiding this comment.
You can specify width and height in pixels by using Frame. See https://stackoverflow.com/a/14897186 for details.
Changing the initial size of the Frame should work.
Line 1417 in 272f6df
| self.notes_list_width = nl_width | ||
| if self.notes_list_height != nl_height and self.config.layout == 'vertical': | ||
| self.config.write_setting('windows', 'notes_list_height', nl_height) | ||
| self.notes_list_height = nl_height |
There was a problem hiding this comment.
Each time you change the window size, nvPY writes configurations to a file. I think that it can reduce configuration write and complex processes by writing configuration just before closing the window. Maybe just change the handler_close().
nvpy/view.py
Outdated
| try: | ||
| if config.pixel_width: | ||
| sentence = 'MmMmMmMmMmMmMmMmMmMmMmMmMmMmMm' | ||
| text_width = int(float(config.pixel_width)/((float(f.measure(sentence)))*.64)*len(sentence)) |
There was a problem hiding this comment.
You can specify width and height in pixels by using Frame. See https://stackoverflow.com/a/14897186 for details.
Changing the initial size of the Frame should work.
Line 1417 in 272f6df
|
@yuuki0xff Thanks for the pointers, that is smarter for saving. As for the frame trick, I had to add the propagate false statement, as well as +17 on save to keep the frame from shrinking on every save (it always shrunk by 17 on save). |
|
Thank you for contributions. |
3 participants
Based on #59 , but updated to work with latest code.
I'm not happy with one part of it, but it works on my machine (both Windows compiled, and running via Linux WSL). May need more testing.