Adding keepPlaying to other player types#1639
Merged
heff merged 7 commits intocookpete:masterfrom Aug 28, 2023
Merged
Conversation
added 7 commits
April 26, 2023 09:05
This an option override to the default pause for Youtube player
Collaborator
|
@LoyalPotato, new maintainer here and getting ramped up. Can you help me understand, is this changing any of the existing behavior or keeping it? Does seekTo have different results depending on which player is used? |
Contributor
Author
|
@heff I believe it's more of an addition of behavior. I kept the default values for the new parameter the same as if they weren't there (so most of them are true since it didn't have any option to pause before). |
Collaborator
|
Great, makes sense. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation on the other pull request ( #1620 ) that added this only to YouTube players.
Also changed the default values from the generic player into each specific player, as YouTube for example, has a different default than the rest.