Code improvement in Discovery

[PChipVIA]

ServiceNow-Monitoring-MP/CookdownCommunity.ServiceNow.Monitoring/Scripts/DiscoverServiceNowMonitoring.ps1

Line 90 in 0791fac

foreach($instance in $instanceUrls.Trim().Split(","))

I would recommend changing the line as follows (code expandable for readability. I personally don't follow that best practice):
foreach($instance in $instanceUrls.Split(',') | %{$_.Trim()} | ? {$_ -notmatch '^\s*$'})

This solves multiple issues:

• If the incoming $instanceUrls contains multiple entries and a space before or after the comma, then each url will be trimmed individually
• Also ensures that only URLs containing data is present
• We could actually force it to match service-now.com in the URL (or add it altogether, with more code)
• As per VSCode PoSH best practices, if a string doesn't need variable expansion, then best to use single quotes
• We could as well put the Where-Object before the For-Each, to filter out before trimming. Haven't checked what is the most efficient.

[P2P-Nathan]

Thanks, @PChipVIA , I'll keep this bug open for the next round of updates to the ServiceNow Monitoring MP.

I think the changes make sense, I can't speak to any performance impacts on the Where-Object mentioned or on the use of single quotes vs double-quotes. I don't use VSCode and had recently been in c# beforehand so my strings may largely be double-quoted...

Thanks for providing this enhancement, it will improve user handling if an odd string is passed in.