-
Notifications
You must be signed in to change notification settings - Fork 239
[WIP] .zuul: Drop testing on Fedora 41 #1733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] .zuul: Drop testing on Fedora 41 #1733
Conversation
Summary of ChangesHello @debarshiray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the continuous integration process by eliminating testing on Fedora 41. This change is a direct response to Fedora 41 reaching its End of Life, ensuring that CI resources are efficiently utilized on supported operating system versions and preventing the execution of tests on an outdated platform. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes CI jobs for Fedora 41 from the Zuul configuration. The justification provided is that Fedora 41 has reached its End of Life. My review highlights a critical issue with this premise: Fedora 41 is an upcoming release and has not reached its End of Life. The change might be based on a misunderstanding of Fedora's release cycle. I've added a comment asking for clarification to ensure the correct Fedora version is being removed from the test matrix, if that is the intent.
I am having trouble creating individual review comments. Click here to see my feedback.
.zuul.yaml (150-181)
These jobs for Fedora 41 are being removed, and the pull request description states this is because Fedora 41 has reached its End of Life. This appears to be incorrect, as Fedora 41 is the upcoming release and has not yet been released, let alone reached its EOL.
Could you please clarify the reason for removing these tests? If the goal is to remove an EOL version, perhaps you meant a different version like Fedora 39 (approaching EOL) or Fedora 38 (already EOL)?
|
This is marked as a draft because Fedora 41 hasn't yet been added to https://docs.fedoraproject.org/en-US/releases/eol/ |
Fedora 41 reached End of Life on ...: https://docs.fedoraproject.org/en-US/releases/eol/ containers#1733
ea3cb86 to
20adc21
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 2m 12s |
Fedora 41 reached End of Life on ...:
https://docs.fedoraproject.org/en-US/releases/eol/