Skip to content

proxy: Fix a hypothetical crash#765

Open
mtrmac wants to merge 1 commit intocontainers:mainfrom
mtrmac:proxy-platform-sig
Open

proxy: Fix a hypothetical crash#765
mtrmac wants to merge 1 commit intocontainers:mainfrom
mtrmac:proxy-platform-sig

Conversation

@mtrmac
Copy link
Copy Markdown
Contributor

@mtrmac mtrmac commented Apr 13, 2026

This is a forward-port of containers/skopeo#2847, which is in itself an update of containers/skopeo#2400 , along with a few more fixes.

Related Red Hat issue: OCPBUGS-81187 .

@packit-as-a-service
Copy link
Copy Markdown

Packit jobs failed. @containers/packit-build please check.

2 similar comments
@packit-as-a-service
Copy link
Copy Markdown

Packit jobs failed. @containers/packit-build please check.

@packit-as-a-service
Copy link
Copy Markdown

Packit jobs failed. @containers/packit-build please check.

@cgwalters
Copy link
Copy Markdown
Contributor

Do you want to roll in some of the test case changes I made in #766 into this?

@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Apr 13, 2026

The tests here are broken, #766 is doing that correctly.

@mtrmac mtrmac marked this pull request as draft April 13, 2026 17:38
Per the existing convention that sysctx indicates all fields
are valid, do not set sysctx when Initialize can still fail.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac force-pushed the proxy-platform-sig branch from ce8665b to 62644b6 Compare April 14, 2026 17:06
@mtrmac mtrmac changed the title proxy: Verify *either* toplevel or target proxy: Fix a hypothetical crash Apr 14, 2026
@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Apr 14, 2026

The bulk of the work was done better in #766, thanks!

Re-using this PR to just contain one crash fix if Initialize failed to set up a signature policy.

@mtrmac mtrmac marked this pull request as ready for review April 14, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to "common" package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants