panic: protobuf tag not enough fields in Status.state

[eclipseo]

Go 1.15 beta 1 , with github.com/gogo/protobuf 1.3.1
Not sure if I amdoung something wrong.

Testing    in: /builddir/build/BUILD/ttrpc-1.0.1/_build/src
         PATH: /builddir/build/BUILD/ttrpc-1.0.1/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/ttrpc-1.0.1/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X github.com/containerd/ttrpc/version=1.0.1 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: github.com/containerd/ttrpc
github.com/containerd/ttrpc
panic: protobuf tag not enough fields in Status.state: 
goroutine 54 [running]:
github.com/gogo/protobuf/proto.(*unmarshalInfo).computeUnmarshalInfo(0x4000120a00)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/table_unmarshal.go:341 +0x1238
github.com/gogo/protobuf/proto.(*unmarshalInfo).unmarshal(0x4000120a00, 0x4000f1a000, 0x4000f16002, 0xf, 0xf, 0xaaaacb74a848, 0x4000026000)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/table_unmarshal.go:138 +0xb50
github.com/gogo/protobuf/proto.makeUnmarshalMessagePtr.func1(0x4000f16002, 0x10, 0x10, 0x4000158420, 0x2, 0x7, 0x4000f87ae8, 0xaaaacb6ebb08, 0x4000f87bc0, 0x756ea1e68af79e)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/table_unmarshal.go:1826 +0xd0
github.com/gogo/protobuf/proto.(*unmarshalInfo).unmarshal(0x4000120960, 0x4000158420, 0x4000f16000, 0x11, 0x11, 0xc, 0x4000f87c48)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/table_unmarshal.go:175 +0x5f4
github.com/gogo/protobuf/proto.(*InternalMessageInfo).Unmarshal(0x4000f0e040, 0xaaaacbbfdde0, 0x4000158420, 0x4000f16000, 0x11, 0x11, 0x4000f87c01, 0x0)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/table_unmarshal.go:63 +0x58
github.com/gogo/protobuf/proto.(*Buffer).Unmarshal(0x4000f23ce0, 0xaaaacbbfdde0, 0x4000158420, 0x0, 0x0)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/decode.go:424 +0x1c4
github.com/gogo/protobuf/proto.Unmarshal(0x4000f16000, 0x11, 0x11, 0xaaaacbbfdde0, 0x4000158420, 0x4000f022b8, 0x4000f87f68)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/decode.go:342 +0x110
github.com/containerd/ttrpc.(*Client).recv(0x4001008580, 0x4000158420, 0x4000f18000, 0x0, 0x0)
	/builddir/build/BUILD/ttrpc-1.0.1/_build/src/github.com/containerd/ttrpc/client.go:323 +0x13c
github.com/containerd/ttrpc.(*Client).run(0x4001008580)
	/builddir/build/BUILD/ttrpc-1.0.1/_build/src/github.com/containerd/ttrpc/client.go:273 +0x354
created by github.com/containerd/ttrpc.NewClient
	/builddir/build/BUILD/ttrpc-1.0.1/_build/src/github.com/containerd/ttrpc/client.go:92 +0x160
exit status 2
FAIL	github.com/containerd/ttrpc	0.514s

[eclipseo]

It seems gogo/protobuf is not compatible with APIv2 protobuf 1.4

gogo/protobuf#678

Since gogo/protobuf is looking for new maintainers, I don't expect this to be "fixable" soon. The best option would be to move to github.com/golang/protobuf.

[fgiudici]

Looked a bit into this: ttrpc relies on gogo/protobuf and imports: google.golang.org/genproto/googleapis/rpc/status
https://github.com/containerd/ttrpc/blob/master/types.go#L22

googleapis are generated via golang protobuf, so newer versions of googleapis bring a different go file. The rcp/status package contains just one status.pb.go file, generated from
https://github.com/googleapis/googleapis/blob/master/google/rpc/status.proto

Here the commit updating the generated code when switching to the newer golang protobuf:
googleapis/go-genproto@8feb7f2#diff-98786b22033f064ef96637aa8531dbe9L32-L45
Note how the struct Status changed, in particular a new member state protoimpl.MessageState
(find it in the file googleapis/rpc/status/status.pb.go).

gogo/protobuf unmarshal code checks explicitly for the older Status struct members (e.g., look as an example at https://github.com/gogo/protobuf/blob/master/proto/table_unmarshal.go#L327 and googleapis/go-genproto@8feb7f2#diff-98786b22033f064ef96637aa8531dbe9L42).

gogo/protobuf unmashal code then panics as it is not able to recognize the newer state member brought in the code generated with the newer protobuf here: https://github.com/gogo/protobuf/blob/master/proto/table_unmarshal.go#L341

---

So, the question is: how will this be handled in the ttrpc package? As seems no one is going to jump on updating the gogo/protobuf, will the gogo/protobuf be dropped in favor of the newer golang/protobuf? It will be not a trivial change but waht could be the other options?

[katiewasnothere]

Is there any update here? We're running into the same error in https://github.com/Microsoft/hcsshim