Skip to content

Conversation

rayokota
Copy link
Member

@rayokota rayokota commented May 10, 2025

Add CEL support for Data Quality rules

What

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@Copilot Copilot AI review requested due to automatic review settings May 10, 2025 21:56
@rayokota rayokota requested review from a team as code owners May 10, 2025 21:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for CEL-based data quality rules by introducing new CEL executors and enhancing the Avro serializer/deserializer tests to cover CEL conditions and field transformations.

  • Added new CEL executors (CelExecutor and CelFieldExecutor) for condition and field transform rules.
  • Extended test coverage in Avro serializer specs with CEL condition, failure, and transform cases.
  • Updated package.json to include the CEL library dependency.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

File Description
schemaregistry/test/serde/avro.spec.ts Updated tests to register and verify CEL rules and transformations.
schemaregistry/rules/cel/cel-field-executor.ts Added a new executor class for CEL-based field transformations.
schemaregistry/rules/cel/cel-executor.ts Introduced a CEL executor for condition-based rules with caching and evaluation.
schemaregistry/package.json Added dependency for the CEL library.

@cprovencher cprovencher added rebase and removed rebase labels May 16, 2025
Copy link
Contributor

@Claimundefine Claimundefine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rayokota rayokota merged commit 1286dc0 into master May 20, 2025
1 of 2 checks passed
@rayokota rayokota deleted the cel-es branch May 20, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants