Skip to content

Conversation

Claimundefine
Copy link
Contributor

Please prefix all TypeScript pull-requests with [Typescript]

What

Prevent additional retries

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@Copilot Copilot AI review requested due to automatic review settings March 20, 2025 22:06
@Claimundefine Claimundefine requested review from a team as code owners March 20, 2025 22:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix the token fetching logic by adding an early return after a successful token retrieval to prevent additional retries.

  • Added an early return statement after setting the token
  • Prevents unnecessary retry attempts after a successful token fetch
Comments suppressed due to low confidence (1)

schemaregistry/oauth/oauth-client.ts:51

  • The 'return;' statement exits the function without returning a value, which might be inconsistent with the function's expected behavior. Consider returning the appropriate value or updating the function signature if a void return is intended.
return;

Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Claimundefine Claimundefine merged commit 1beb343 into master Mar 20, 2025
1 of 2 checks passed
@Claimundefine Claimundefine deleted the fix-oauth-retry branch March 20, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants