Organize blockhash as a module#11
Open
zorkian wants to merge 1 commit intocommonsmachinery:masterfrom
Open
Conversation
This makes blockhash install as a module which makes it possible to be packaged in bazel rules, but is probably also slightly more useful in general. This also updates to use setuptools and converts the script to an entry_point which will make it more broadly supported on different platforms.
artfwo
reviewed
May 19, 2019
| interpolation = Image.ANTIALIAS | ||
|
|
||
| if args.quick: | ||
| method = blockhash_even |
Member
There was a problem hiding this comment.
blockhash_even is not imported above, is this gonna work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes blockhash install as a module which makes it possible to be
packaged in bazel rules, but is probably also slightly more useful in
general.
This also updates to use setuptools and converts the script to an
entry_point which will make it more broadly supported on different
platforms.