-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Honda - clear startup Bosch faults #3029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Testing 154 segments for: HONDA_ACCORD, HONDA_CIVIC_BOSCH, HONDA_CIVIC_2022, HONDA_CRV_5G, HONDA_CRV_HYBRID, HONDA_HRV_3G, HONDA_INSIGHT, HONDA_E, HONDA_PILOT_4G, HONDA_CRV, HONDA_FIT, HONDA_FREED, HONDA_HRV, HONDA_ODYSSEY, HONDA_PILOT, HONDA_RIDGELINE, HONDA_CIVIC Results: 153 passed, 1 with diffs, 0 errors |
|
Do we know why they happen in the first place and how to avoid them? I vaguely remember stock LKAS trying to actuate and it not seeing the EPS react or something might be one cause? |
|
We don't know how to avoid the Bosch C faults during the next drive after long control is enabled. The car is somehow detecting the absence of a radar from a prior drive. During the occasional times I had Bosch C loaners I attempted to match every message from stock vs hondacan and it still faulted. My next attempt will be to find all the other messages that shut down when the radar is disabled and attempt to send a default value across all of them. Other than above, the only reason for a fault has been loose/bad wiring. Or snow on the radar. This PR would allow successful usage in the first drive after these faults, rather than the current state where you need to drive until the fault clears, and then restart the engine for an opportunity for cruise to resume. |
Bosch cars retain faults from prior drives during the next time they start up. They clear within a minute of the new drive.
This PR disables cruise enable (which is reversible) for any faults that appear in the first 10 seconds, and allows them time to clear. 10 seconds was chosen because Bosch C startup faults seem to occur upon gateway open, which occurs around 7 seconds after startup.
Any faults after 10 seconds have normal accFaulted (permanent, until restarting engine) carstate flagged.
Recent drive from a canfd loaner: ad9840558640c31d/00000195--03d04b0d1c