Only include a subset of icons in yaegicore to reduce binary size#1527
Merged
Only include a subset of icons in yaegicore to reduce binary size#1527
Conversation
rcoreilly
approved these changes
May 19, 2025
Member
rcoreilly
left a comment
rcoreilly
left a comment
There was a problem hiding this comment.
note: can extend this manual list by adding to Symbols in this package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of including all icons in
yaegicore, we only include a subset (the icons we use in docs). This reduces binary size by around 2 MB on native and 3 MB on web. That is around 700 KB on compressed wasm, which is around 5% of the total web binary size.Fixes #1473