Skip to content

fix free calls in L and wrap#101

Merged
JohanWiltink merged 2 commits intocodewars:mainfrom
JohanWiltink:main
Jan 29, 2024
Merged

fix free calls in L and wrap#101
JohanWiltink merged 2 commits intocodewars:mainfrom
JohanWiltink:main

Conversation

@JohanWiltink
Copy link
Collaborator

allow for JS values ( number literals in custom encodings ) as abstraction bodies and expressions

fixes #99 ; the same problem happened in L bodies ( thanks to @monadius for pointing that out )

Johan Wiltink added 2 commits January 26, 2024 04:08
allow for JS values as abstraction bodies and expressions ( number literals in custom encoding )
@JohanWiltink JohanWiltink added the bug Something isn't working label Jan 26, 2024
@JohanWiltink JohanWiltink requested a review from Kacarott January 26, 2024 03:16
@JohanWiltink JohanWiltink self-assigned this Jan 26, 2024
Copy link
Collaborator

@Kacarott Kacarott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok to me, though I am not totally sure what is term.free() even does. In general I am not very familiar with this section of the code

@JohanWiltink JohanWiltink merged commit 0c44a2a into codewars:main Jan 29, 2024
@JohanWiltink
Copy link
Collaborator Author

free determines the free variables in a term. If that term is in JS, it doesn't have free variables, but it also doesn't have a method free, so it should return an empty Set instead of calling undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Number literals in custom encoding can't be wrapped

2 participants