Fix mistakes

[sebweb3r]

I had a longer look on the dictionary and found some mistakes.

[sebweb3r]

According to https://en.wiktionary.org/wiki/permuter#English
permuter is a valid word

[sebweb3r]

continueq seems to be used in some linux headers!?

[lurch]

Looks like contryie->countryie might also be a mistake? https://www.google.com/search?q=%22countryie%22
Perhaps it should be contryie->country, countries, ?

[peternewman]

A few comments

[vikivivi]

@sebweb3r Sorry, not aware of your #1624. Please help by include everything from #1643, so that I can withdraw #1643. Thank you

[sebweb3r]

@sebweb3r Sorry, not aware of your #1624. Please help by include everything from #1643, so that I can withdraw #1643. Thank you

No problem. It is done.

[sebweb3r]

push @peternewman

[peternewman]

A few more comments

[sebweb3r]

should be finished @peternewman

[peternewman]

A few more comments.

[sebweb3r]

push @peternewman

[peternewman]

A few more comments

[sebweb3r]

@peternewman I rebased the MR. the conflict was in the lines

miniscully->minusculy
miniscully->minusculely
ministery->ministry, minister,

where the ministery line was changed in a different MR.

All now open comments, I would like to handle in a new MR.

[peternewman]

@peternewman I rebased the MR. the conflict was in the lines

miniscully->minusculy
miniscully-> minusculely
ministery->ministry, minister,

where the ministery line was changed in a different MR.

Great thanks, that was possibly in @lurch 's.

All now open comments, I would like to handle in a new MR.

Okay, it's two additions and one change. Can we get the change in her at least, and a new PR open for the additions. Otherwise we've got to remember to do them when you've merged this.

FWIW this is one of the reasons why I often suggest smaller PRs are better, although at least this one isn't as unmanageable as some we've had in the past.

[sebweb3r]

All now open comments, I would like to handle in a new MR.

Okay, it's two additions and one change. Can we get the change in her at least, and a new PR open for the additions. Otherwise we've got to remember to do them when you've merged this.

I added all open comments.

FWIW this is one of the reasons why I often suggest smaller PRs are better, although at least this one isn't as unmanageable as some we've had in the past.

Yeah, I like smaller PRs too. But i thought 25 lines initially is small enough. It exploded a little bit.

[peternewman]

Some additional variants

[peternewman]

FWIW this is one of the reasons why I often suggest smaller PRs are better, although at least this one isn't as unmanageable as some we've had in the past.

Yeah, I like smaller PRs too. But i thought 25 lines initially is small enough. It exploded a little bit.

I suspect this got extra attention given it was fixing mistakes. But I'd also generally imagine that if you're touching more than say 10-15 parts of the file it can also explode a bit, as we potentially end up inspecting bits of the data you didn't even change. Whereas if its a handful of base words with a lot of variants each then less of the file overall gets reviewed.

[lurch]

... It exploded a little bit.

Sorry about that! 💥 🤣
My eagle-eyes are too good at spotting mistakes 😉 👀 🔍

[peternewman]

LGTM thanks for fixing these bugs!

Same thing @lurch , any comments from you?

[lurch]

Hmmm, if we're offering affinitize as a correction, does it make sense to report affinitized as an error?
https://www.google.com/search?q=affinitize
🤷

[peternewman]

Possibly not then. -ed is more popular in Google Books than -e too! http://app.aspell.net/lookup?dict=en_US-large&words=affinitize

[sebweb3r]

I couldn't find affinitize in an english dictionary. and my german dictionaries/deepl have some really strange suggestions.

So let it in or throw it out?

[peternewman]

We should probably allow affinitized too really, or at least not correct it.

[peternewman]

Thanks @sebweb3r

[lurch]

Woohoo, we finally got there! Well done everyone 👏

[sebweb3r]

🎉