Skip to content

Fix google map CSS class and API key in HTML templates #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsalvino merged 2 commits into from
Aug 2, 2020
Merged

Fix google map CSS class and API key in HTML templates #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c04b0a3
Fix google map CSS class and API key in HTML templates
vsalvino Aug 2, 2020
bf6df39
Add release notes
vsalvino Aug 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions coderedcms/templates/coderedcms/blocks/google_map.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<div class="embed-responsive embed-responsive-16by9 {{self.settings.custom_css_clas}}"
<div class="embed-responsive embed-responsive-16by9 {{self.settings.custom_css_class}}"
{% if self.settings.custom_id %}id="{{self.settings.custom_id}}"{% endif %}>
{% if self.place_id %}
<iframe class="embed-responsive-item" width="100%" style="border:0" src="https://www.google.com/maps/embed/v1/place?q=place_id:{{ self.place_id }}&zoom={{ self.map_zoom_level }}&key={{ settings.GoogleApiSettings.google_maps_api_key}}" title="{{self.map_title}}" allowfullscreen></iframe>
{% else %}
<iframe class="embed-responsive-item" width="100%" style="border:0" src="https://maps.google.com/maps?q={{ self.search|urlencode }}&output=embed" title="{{self.map_title}}" allowfullscreen></iframe>
{% endif %}
{% if self.place_id %}
<iframe class="embed-responsive-item" width="100%" style="border:0" src="https://www.google.com/maps/embed/v1/place?q=place_id:{{ self.place_id }}&zoom={{ self.map_zoom_level }}&key={{ settings.coderedcms.GoogleApiSettings.google_maps_api_key}}" title="{{self.map_title}}" allowfullscreen></iframe>
{% else %}
<iframe class="embed-responsive-item" width="100%" style="border:0" src="https://maps.google.com/maps?q={{ self.search|urlencode }}&output=embed" title="{{self.map_title}}" allowfullscreen></iframe>
{% endif %}
</div>
2 changes: 2 additions & 0 deletions docs/releases/v0.19.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Bug fixes
* Support custom image models by correctly using ``WAGTAILIMAGES_IMAGE_MODEL``
versus hard-coding ``wagtailimages.Image``.

* Fix custom CSS class and Google Maps API key in Google Map block.

* ``coderedcms start`` now pins the version of CodeRed CMS in the generated
``requirements.txt`` file.

Expand Down