Use context.AfterFunc() instead of a goroutine to track timeouts
#532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacalz
approved these changes
Aug 19, 2025
mafredri
reviewed
Sep 3, 2025
mafredri
reviewed
Sep 4, 2025
ash2k
force-pushed
the
no-timeout-goroutine
branch
from
1c2984a to
05e7b4b
Compare
|
Thanks for merging! If you could tag a release, I'd deploy to prod and see what happens 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reworked version of #501 with some minor improvements.
Closes #411
Closes #501