Fix unit tests on windows #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
reviewed
Oct 13, 2025
mafredri
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
I think the changes largely look good but some of the shell manipulation functions are a bit misleading in that they require a certain form of input and are easily broken (at least via quick inspection).
Even thought he cases are currently simple, it might be worth pulling in a dev-module for the tests.
EhabY
force-pushed
the
fix-tests-on-windows
branch
from
9167249 to
bf9a1c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #604