Use VS Code's LogOutputChannel for logging #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EhabY
commented
Jul 15, 2025
matifali
requested review from
aslilac and
code-asher
and removed request for
code-asher
code-asher
approved these changes
Jul 15, 2025
|
Ah and I mentioned
I think you are right, looking at the |
aslilac
approved these changes
Jul 15, 2025
…g from error to warn
|
Probably requires another review now that I replaced all the calls of |
|
HI @EhabY. Thanks for your contribution. Could you also add the change to https://github.com/coder/vscode-coder/blob/main/CHANGELOG.md |
|
Added the change to the changlog |
|
Ah right yeah, adding a line to the changelog in the PR is the best way yeah. |
code-asher
reviewed
Jul 17, 2025
EhabY
force-pushed
the
use-logging-output-vscode
branch
from
71d9254 to
029711f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #257
In this PR I create a
LogOutputChannelinstead of the oldOutputChannel. By default,appendLineuses theinfologging level so I usedinfoto log most messages, except errors where theerrorlevel was used.I think all of the info can be downgraded into
debuglevel actually, and the errors could be downgraded intowarnsince they are handled or thrown right away. What do you think?