Start workspaces by shelling out to CLI #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the REST-API-based start flow with one that shells out to the coder CLI. Signed-off-by: Aaron Lehmann <alehmann@netflix.com>
aaronlehmann
force-pushed
the
start-with-cli
branch
from
f8319a8 to
59ac05c
Compare
code-asher
reviewed
Nov 21, 2024
|
Thanks for reviewing! I'm traveling right now but will come back to this in early December. |
code-asher
reviewed
Dec 5, 2024
src/storage.ts
Outdated
Comment on lines
511
to
513
| await fs.stat(oldTokenPath) | ||
| const newTokenPath = this.getSessionTokenPath(label) | ||
| await fs.rename(oldTokenPath, newTokenPath) |
There was a problem hiding this comment.
Not a blocker at all, just wanted to mention that stat is often an anti-pattern; because rename can also throw ENOENT and there is technically no guarantee the file still exists between the stat and rename, it is always necessary to check the error of rename anyway, so might as well do it with one call.
There was a problem hiding this comment.
Right, that makes sense. Removed the stat.
Co-authored-by: Asher <ash@coder.com>
code-asher
approved these changes
Dec 6, 2024
aaronlehmann
pushed a commit
to aaronlehmann/jetbrains-coder
that referenced
this pull request
Dec 24, 2024
Replace the REST-API-based start flow with one that shells out to the coder CLI. This is the JetBrains extension equivalent to coder/vscode-coder#400.
code-asher
pushed a commit
to coder/jetbrains-coder
that referenced
this pull request
Jan 3, 2025
Replace the REST-API-based start flow with one that shells out to the coder CLI. This is the JetBrains extension equivalent to coder/vscode-coder#400.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the REST-API-based start flow with one that shells out to the coder CLI.