-
Notifications
You must be signed in to change notification settings - Fork 81
fix(claude-code): change mcp add command to use mcp add-json instead #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug in the Claude Code module by correcting the MCP (Model Context Protocol) server configuration command from claude mcp add to claude mcp add-json. The module version is bumped from 4.2.1 to 4.2.2 to reflect this bug fix.
Key changes:
- Updated the MCP server add command to use the correct
add-jsonsubcommand in the installation script - Bumped module version to 4.2.2 across all README examples
- Fixed JSON syntax error in README example by adding missing trailing comma
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| registry/coder/modules/claude-code/scripts/install.sh | Changed claude mcp add command to claude mcp add-json for proper MCP server configuration |
| registry/coder/modules/claude-code/README.md | Updated version references from 4.2.1 to 4.2.2 in all example code blocks; fixed JSON syntax by adding trailing comma to MCP server configuration example |
matifali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does it close #562?
|
This should but I'm thoroughly testing this to make sure there are no more hiccups with mcp servers and claude-code |
|
There was an issue with the mcp servers being set for the root dir rather than the workdir and this has been addressed as well. I have tested this, and updated the mcp config usage example to with a real world example as well |
Description
changes the
claude-code mcp addcommand toclaude-code mcp add-jsoninstead, and updates usage examples with real world mcp server example.Type of Change
Module Information
Path:
registry/coder/modules/claude-codeNew version:
v4.2.2Breaking change: [ ] Yes [X] No
Testing & Validation
bun test)bun fmt)Related Issues
#562