-
Notifications
You must be signed in to change notification settings - Fork 6
feat: update prebuilds dashboard with build time metrics #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! Left a few thoughts.
coder-observability/templates/dashboards/_dashboards_prebuilds.json.tpl
Outdated
Show resolved
Hide resolved
coder-observability/templates/dashboards/_dashboards_prebuilds.json.tpl
Outdated
Show resolved
Hide resolved
coder-observability/templates/dashboards/_dashboards_prebuilds.json.tpl
Outdated
Show resolved
Hide resolved
coder-observability/templates/dashboards/_dashboards_prebuilds.json.tpl
Outdated
Show resolved
Hide resolved
coder-observability/templates/dashboards/_dashboards_prebuilds.json.tpl
Outdated
Show resolved
Hide resolved
10, | ||
10 | ||
], | ||
"fill": "dash" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why you chose to make this dashed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make a visual distinction between the other panels. But I can change it to Solid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Update the prebuilds dashboard to compare key metrics between regular and prebuilt workspaces, and to surface prebuilt creation vs claim timings.
Changes
preset
label.Screenshot
Link
Internal Grafana dashboard: https://grafana.dev.coder.com/goto/WEthVFrHR?orgId=1