impl: add the option to disable ssh wildcard configuration #584
Conversation
It will be used later by the Coder Settings view to allow users to enable or disable SSH hostname wildcard configuration.
Updated the UI component to allow configuration by the user
when generating the ssh config for Coder Gateway. Up until now we just checked if the Coder deployment supports this feature, but now users have to option to continue to use expanded hostnames in the ssh config.
Qodana Community for JVM34 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.3.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
CLIManager can be created with default settings (simplifies testing), among which the ssh wildcard config is enabled. But in reality the config can be disabled by the user.
…rd config was changed Currently, if a user starts a connection with wildcard enabled and then later on it disables the wildcard config then the recent connections becomes unusable because the hostnames are invalid. The issue can reproduce the other way around as well (start with wildcard ssh config disabled, start an IDE and then later on enable wildcard config) This commit addresses the issue by resolving the hostname on demand when the user wants to open the remote IDE from the recent connections panel.
Connections started with two different hostnames (because of the ssh wildcard config) can be rendered twice in the Recent projects panel. With this commit we ignore the hostname and instead use the workspace name and deployment URL.
There is apparently a client that has issues with wildcard config, "After the SSH configuration changes introduced with jetbrains-coder in Version 2.18 (f39e1f4) we are no longer able to connect JetBrains Gateway to our workspaces (Failed to retrieve IDEs / Host is unknown)." They requested a way to disable the wildcard configuration. Probably it makes more sense to understand the issue they have with this configuration but unfortunately they haven't provided any logs. And on the other hand, Coder Toolbox already provides both options (wildcard enabled or disabled) |
|
Ahh gotcha that makes sense! |
It will be used later by the Coder Settings view to allow users to enable or disable SSH hostname wildcard configuration.