Add the ability to disable autostart

[code-asher]

On macOS this is checked by default for 2.5.0 and above.

Closes #365

[github-actions]

Qodana Community for JVM

47 new problems were found

Inspection name	Severity	Problems
Unused symbol	🔶 Warning	26
Unstable API Usage	🔶 Warning	8
Incorrect string capitalization	🔶 Warning	7
Redundant qualifier name	🔶 Warning	2
Call to 'equals()' or 'hashCode()' on 'URL' object	🔶 Warning	2
Redundant semicolon	🔶 Warning	1
Redundant empty primary constructor	◽️ Notice	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

1. Register at Qodana Cloud and configure the action
2. Use GitHub Code Scanning with Qodana
3. Host Qodana report at GitHub Pages
4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.0
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[johnstcn]

Some suggestions, but LGTM apart from that.

[johnstcn]

Suggestion: refactor to configSsh(options: configSSHOptions) where options consists of

  workspaceNames: List<String>
  disableAutostart: boolean

This allows you to then simplify the logic in line 235 to

if (opts.disable-autostart) "--disable-autostart" else null

and move the version checking logic outside of modifySSHConfig()

[code-asher]

I was thinking of something like this! But then it felt weird because sometimes we would use the settings (for header command) and sometimes not (for disable autostart). Maybe a supports or features object that has keys for what features are supported then I have settings.disableAutostart && supports.disableAutostart.

[johnstcn]

Gotcha, that would definitely make things more confusing. Not a blocker for me in any case.