Support agent ID parameter #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
asher/agent-id
branch
2 times, most recently
from
b421edc to
00231a3
Compare
code-asher
force-pushed
the
asher/agent-id
branch
from
00231a3 to
a13c2ef
Compare
Qodana Community for JVM53 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.2.6
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
johnstcn
reviewed
Oct 16, 2023
src/main/kotlin/com/coder/gateway/CoderGatewayConnectionProvider.kt
Outdated
Show resolved
Hide resolved
It should omit agent information when the workspace specifies no agents and the name should combine the workspace and agent names.
This generates agent models, not workspaces. Renaming opens the way for generating random workspaces.
code-asher
force-pushed
the
asher/agent-id
branch
from
2c52d1a to
3b1804b
Compare
I also made a tweak to check that the agent ID is not null since toAgentModels() will return the workspace without any agent bits set if there are no agents. And the wrong error message would show when either the id or name were missing. I also flipped them around while fixing this to match the order above it.
code-asher
force-pushed
the
asher/agent-id
branch
from
3b1804b to
691c276
Compare
johnstcn
approved these changes
Oct 17, 2023
Comment on lines
+10
to
+13
| // TODO: Maybe better to randomly generate the workspace and then call | ||
| // toAgentModels() on it. Also the way an "agent" model can have no | ||
| // agent in it seems weird; can we refactor to remove | ||
| // WorkspaceAgentModel and use the original structs from the API? |
There was a problem hiding this comment.
👍 to this, I'm assuming we auto-generate the API? I wonder if we could gen the field values from the spec.
There was a problem hiding this comment.
Oh that would be absolutely wonderful. The API types appear to be hand-written at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #292
This will let you set the agent by either ID or name. If both are set then the name is ignored.