Skip to content

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Oct 3, 2023

Closes #305

This contains the code changes, but looks like we will have to publish a separate version because launchUnderBackgroundProgress, while the usage is the same, fails if you do not update the platform version of the plugin. It had an optional parameter but now uses overloads, and I guess something there is wonky even if the call itself is compatible with both.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Qodana Community for JVM

55 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 32
Unstable API Usage 🔶 Warning 8
Incorrect string capitalization 🔶 Warning 7
Call to 'equals()' or 'hashCode()' on 'URL' object 🔶 Warning 2
Local 'var' is never modified and can be declared as 'val' 🔶 Warning 1
Redundant semicolon 🔶 Warning 1
Useless call on not-null type 🔶 Warning 1
Class member can have 'private' visibility ◽️ Notice 1
Size check can be replaced with 'isNotEmpty()' ◽️ Notice 1
Trailing comma recommendations ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.6
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@code-asher code-asher force-pushed the gateway-233 branch 2 times, most recently from 17c640e to 528836f Compare October 3, 2023 19:14
Maybe it was moved or something.

Unfortunately this means we have to use a wildcard because in previous
versions it was not a separate import.
I guess `launch` alone is no longer allowed.
@code-asher code-asher marked this pull request as ready for review October 3, 2023 19:48
@code-asher code-asher force-pushed the gateway-233 branch 3 times, most recently from b4eeb24 to 0804f2b Compare October 3, 2023 20:02
Also, getting an error about project being null so just remove it.  It
is now an overload where the project is not specified at all.
Previously it was an optional parameter, so it should still work in all
versions.
This changed to automatically use the token, no confirmation.
@code-asher code-asher merged commit 632e840 into main Oct 3, 2023
@code-asher code-asher deleted the gateway-233 branch October 3, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Gateway 2023.3
1 participant