More retry #236
Merged
More retry #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving back to a draft while I add another retry elsewhere. |
It seems to operate in its own little world and I have no idea how to make it stop when the job running it has stopped.
code-asher
force-pushed
the
more-retry
branch
3 times, most recently
from
dbb90a6 to
7685b37
Compare
This will cover recent connections which connect directly without going through the whole setup flow. Pretty much the same logic as for listing editors but we display the errors in different ways since this all happens in a progress dialog. I tried to combine what I could in the retry. Also the SshException is misleading; it seems to wrap the real error so unwrap it otherwise it is impossible to tell what is really wrong. In particular this is causing us to retry on cancelations.
johnstcn
approved these changes
Apr 28, 2023
| import kotlin.coroutines.cancellation.CancellationException | ||
| import kotlin.math.min | ||
|
|
||
| fun unwrap(ex: Exception): Throwable? { |
There was a problem hiding this comment.
Does Kotlin not have the equivalent of errors.Cause?
There was a problem hiding this comment.
Nothing that I could find unfortunately.
src/main/kotlin/com/coder/gateway/CoderGatewayConnectionProvider.kt
Outdated
Show resolved
Hide resolved
If there is no cause we use the existing exception so this will never be null.
code-asher
force-pushed
the
more-retry
branch
3 times, most recently
from
87ca9ed to
a2d42d2
Compare
code-asher
force-pushed
the
more-retry
branch
2 times, most recently
from
bdb02b0 to
2b1c082
Compare
johnstcn
reviewed
May 2, 2023
Comment on lines
+48
to
+50
| retryIf = { | ||
| it is ConnectionException || it is TimeoutException | ||
| || it is SSHException || it is DeployException |
johnstcn
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added retry for recent connections, munged the deploy error so it is a bit more friendly, and unwrapped
SshExceptionsince it was masking the real errors making it especially difficult to stop retrying on cancelation.