Skip to content

Preserve selection when workspace starts/stops #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Preserve selection when workspace starts/stops #233

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c138d09
Extract randWorkspace to shared class
code-asher Apr 26, 2023
f9c8573
Break out workspaces table
code-asher Apr 26, 2023
a83b0bc
Preserve selection when workspaces starts or stops
code-asher Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Extract randWorkspace to shared class
  • Loading branch information
@code-asher
code-asher committed Apr 26, 2023
commit c138d0968613ecc27a92bd58507f848914f435db
26 changes: 1 addition & 25 deletions src/test/groovy/CoderCLIManagerTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
package com.coder.gateway.sdk

import com.coder.gateway.models.WorkspaceAgentModel
import com.coder.gateway.models.WorkspaceAndAgentStatus
import com.coder.gateway.models.WorkspaceVersionStatus
import com.coder.gateway.sdk.v2.models.WorkspaceStatus
import com.coder.gateway.sdk.v2.models.WorkspaceTransition
import com.sun.net.httpserver.HttpExchange
import com.sun.net.httpserver.HttpHandler
import com.sun.net.httpserver.HttpServer
Expand Down Expand Up @@ -364,25 +359,6 @@ class CoderCLIManagerTest extends Specification {
Path.of("/tmp/coder-gateway-test/localappdata/coder-gateway") == dataDir()
}

private WorkspaceAgentModel randWorkspace(String name) {
return new WorkspaceAgentModel(
UUID.randomUUID(),
name,
name,
UUID.randomUUID(),
"template-name",
"template-icon-path",
null,
WorkspaceVersionStatus.UPDATED,
WorkspaceStatus.RUNNING,
WorkspaceAndAgentStatus.READY,
WorkspaceTransition.START,
null,
null,
null
)
}

def "configures an SSH file"() {
given:
def sshConfigPath = tmpdir.resolve(input + "_to_" + output + ".conf")
Expand All @@ -401,7 +377,7 @@ class CoderCLIManagerTest extends Specification {
.replace("/tmp/coder-gateway/test.coder.invalid/coder-linux-amd64", ccm.localBinaryPath.toString())

when:
ccm.configSsh(workspaces.collect { randWorkspace(it) })
ccm.configSsh(workspaces.collect { DataGen.workspace(it) })

then:
sshConfigPath.toFile().text == expectedConf
Expand Down
26 changes: 26 additions & 0 deletions src/test/groovy/DataGen.groovy
View file
Open in desktop
Copy link
Member

@johnstcn johnstcn Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice

Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import com.coder.gateway.models.WorkspaceAgentModel
import com.coder.gateway.models.WorkspaceAndAgentStatus
import com.coder.gateway.models.WorkspaceVersionStatus
import com.coder.gateway.sdk.v2.models.WorkspaceStatus
import com.coder.gateway.sdk.v2.models.WorkspaceTransition

class DataGen {
static WorkspaceAgentModel workspace(String name, String workspaceName = name) {
return new WorkspaceAgentModel(
UUID.randomUUID(),
workspaceName,
name,
UUID.randomUUID(),
"template-name",
"template-icon-path",
null,
WorkspaceVersionStatus.UPDATED,
WorkspaceStatus.RUNNING,
WorkspaceAndAgentStatus.READY,
WorkspaceTransition.START,
null,
null,
null
)
}
}