Fix: progress icon spin in combo box #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the progress icon in the IDE selection combo box was not
spinning while IDEs were loading.
- there were two reasons:
1. the combobox did not enable animated icons in the
renderer
2. the cell renderer implementation did not repaint
the icon
- resolves #4
- the IDEs combobox is no longer stuck with the text "Retrieving products.." if an exception happens in the code. - instead, exceptions are handled a new custom combo box renderer is installed that tells the user that an error was encountered while retrieving the IDEs. - resolves #10
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the progress icon in the IDE selection combo box was not
spinning while IDEs were loading.
there were two reasons:
renderer
the icon
resolves
Retrieving IDE…label doesn’t animate the spinning icon in the last wizard panel #4the IDEs combobox is no longer stuck with the text "Retrieving
products.." if an exception happens in the code.
instead, exceptions are handled a new custom combo box renderer
is installed that tells the user that an error was encountered
while retrieving the IDEs.
resolves Coder Gateway plugin is continuing to render
Retrieving products...when target OS can't be determined #10