Skip to content

Address Qodana and plugin verifier inspections #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 21, 2022
Merged

Address Qodana and plugin verifier inspections #20

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f5fb90a
Delete unused coder V1 models
fioan89 Jun 21, 2022
eb1e60a
Remove property declaration in constructor if is never used
fioan89 Jun 21, 2022
ddcc959
Use proper naming convention in enums
fioan89 Jun 21, 2022
b1f36a2
Use literal argument with param name
fioan89 Jun 21, 2022
e0fab54
Remove redundant nullable return type
fioan89 Jun 21, 2022
a4a45f6
Remove useless call on not-null type
fioan89 Jun 21, 2022
dff6559
Remove unused methods
fioan89 Jun 21, 2022
0d37a99
Remove usage of internal API
fioan89 Jun 21, 2022
0c1b0fc
Suppress warnings about string capitalization
fioan89 Jun 21, 2022
e7065b2
Make field private
fioan89 Jun 21, 2022
ca4bc3b
Suppress warning about unstable API usage
fioan89 Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove property declaration in constructor if is never used
  • Loading branch information
@fioan89
fioan89 committed Jun 21, 2022
commit eb1e60ad97f0aa4e8a542f8ccde7e9d34ebf2388
2 changes: 1 addition & 1 deletion src/main/kotlin/com/coder/gateway/sdk/CoderCLIManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import com.intellij.openapi.diagnostic.Logger
import java.net.URL
import java.nio.file.Path

class CoderCLIManager(private val url: URL, private val buildVersion: String) {
class CoderCLIManager(private val url: URL, buildVersion: String) {
private val coderCLIDownloader = CoderCLIDownloader(buildVersion)

fun download(): Path? {
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/com/coder/gateway/sdk/ex/AuthenticationException.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ package com.coder.gateway.sdk.ex

import java.io.IOException

class AuthenticationException(val reason: String) : IOException(reason)
class AuthenticationException(reason: String) : IOException(reason)
2 changes: 1 addition & 1 deletion src/main/kotlin/com/coder/gateway/views/CoderGatewayConnectionComponent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import com.intellij.util.ui.components.BorderLayoutPanel
import com.jetbrains.rd.util.lifetime.Lifetime
import com.jetbrains.rd.util.lifetime.onTermination

class CoderGatewayConnectionComponent(val lifetime: Lifetime, val url: String) : BorderLayoutPanel() {
class CoderGatewayConnectionComponent(lifetime: Lifetime, val url: String) : BorderLayoutPanel() {
private val disposable = Disposer.newDisposable()
private val mainPanel = BorderLayoutPanel().apply {
add(JBLabel(CoderIcons.LOGO_52), "Center")
Expand Down