Skip to content

fix: relaxed Content-Type checks for CLI download #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

fix: relaxed Content-Type checks for CLI download #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Fixed

- NPE during error reporting
- relaxed `Content-Type` checks while downloading the CLI

## 0.6.3 - 2025-08-25

Expand Down
14 changes: 13 additions & 1 deletion src/main/kotlin/com/coder/toolbox/cli/downloader/CoderDownloadService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,18 @@ import java.util.zip.GZIPInputStream
import kotlin.io.path.name
import kotlin.io.path.notExists

private val SUPPORTED_BIN_MIME_TYPES = listOf(
"application/octet-stream",
"application/exe",
"application/dos-exe",
"application/msdos-windows",
"application/x-exe",
"application/x-msdownload",
"application/x-winexe",
"application/x-msdos-program",
"application/x-msdos-executable",
"application/vnd.microsoft.portable-executable"
)
/**
* Handles the download steps of Coder CLI
*/
Expand Down Expand Up @@ -52,7 +64,7 @@ class CoderDownloadService(
return when (response.code()) {
HTTP_OK -> {
val contentType = response.headers()["Content-Type"]?.lowercase()
if (contentType?.startsWith("application/octet-stream") != true) {
if (contentType !in SUPPORTED_BIN_MIME_TYPES) {
throw ResponseException(
"Invalid content type '$contentType' when downloading CLI from $remoteBinaryURL. Expected application/octet-stream.",
response.code()
Expand Down
Loading