Skip to content

Conversation

jinvien
Copy link

@jinvien jinvien commented Sep 6, 2025

Description
This PR fixes a URL path issue in the Open VSX marketplace integration that was causing incorrect redirects.

Problem
vscode extension gallery was generating incorrect URLs with an extra /vscode segment:

❌ Incorrect: https://open-vsx.org/vscode/gallery/vscode/eamodio/gitlens/latest
✅ Correct: https://open-vsx.org/vscode/gallery/eamodio/gitlens/latest
The incorrect URL format was causing redirects to http://open-vsx.org/error instead of properly resolving extension resources.

Changes
Fixed the extension latest version URI template in extensionGalleryManifestService.ts by removing the redundant /vscode segment

@jinvien jinvien requested a review from a team as a code owner September 6, 2025 09:33
@code-asher
Copy link
Member

Ohhhhhhh interesting is this why extension installations sometimes fail??

But, I am not sure if we can merge this because there are other marketplaces (such as code-marketplace) that do include the /vscode so this would break those.

Also, what about other VS Code-based alternatives like VSCodium? I imagine they must have the same bug. Maybe this needs to be fixed on Open VSX's side?

If not, then maybe we will need to pull this off extensionsGallery instead so it can be customized.

@code-asher
Copy link
Member

code-asher commented Sep 8, 2025

Actually, eclipse/openvsx#1283 suggests we can set extensionUrlTemplate on extensionsGallery to fix this. Looks like VSCodium works because it sets this, so we can do the same (in this same patch).

@jinvien
Copy link
Author

jinvien commented Sep 9, 2025

Yes, this is clearly a more elegant solution. I've updated the commit accordingly—please take a look when you have a moment.

Also, I’m not entirely sure whether my commit should include changes to changelog.md. I noticed in your contribution guidelines that updates related to the marketplace should be reflected in the changelog. Could you please advise on whether that’s needed here?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants