feat: cli arg for file permission of socket #4923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
approved these changes
Feb 28, 2022
Contributor
jsjoeio
left a comment
jsjoeio
left a comment
There was a problem hiding this comment.
Very clean PR 👏 Thank you for adding tests as well!
I'm less familiar with socket-permissions so I'll defer review to @code-asher
Codecov Report
@@ Coverage Diff @@
## main #4923 +/- ##
=======================================
Coverage 70.29% 70.30%
=======================================
Files 29 29
Lines 1670 1677 +7
Branches 369 371 +2
=======================================
+ Hits 1174 1179 +5
- Misses 422 424 +2
Partials 74 74
Continue to review full report at Codecov.
|
code-asher
requested changes
Mar 2, 2022
Member
code-asher
left a comment
code-asher
left a comment
There was a problem hiding this comment.
Thank you for the contribution! This has been a long-standing one.
code-asher
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1466
Add a cli option
--socket-permission, and set file mode accordingly when listening a socket.