install.sh: Allow customizing remote shell for remote installation #2220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
force-pushed
the
remote-install-5bc0
branch
2 times, most recently
from
fd908ff to
650c88c
Compare
code-asher
requested changes
Oct 21, 2020
nhooyr
force-pushed
the
remote-install-5bc0
branch
from
f227d55 to
bf98ad7
Compare
nhooyr
force-pushed
the
remote-install-5bc0
branch
from
bf98ad7 to
a0b7bf2
Compare
nhooyr
changed the title
code-asher
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1729
Last TODO left on that issue. I removed making remote installation on a non internet connected instance work as I don't think that's a very common use case and if it is, manual installation isn't hard anyway. It'll require lots of churn and make the install script quite abstract and hard to understand.