Skip to content

docker: Fix $DOCKER_USER #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2020
Merged

docker: Fix $DOCKER_USER #2057

merged 1 commit into from
Sep 3, 2020

Conversation

@nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Sep 3, 2020 •
edited
Loading

We do not try renaming $HOME anymore as there is no good way
to do it.

We also only try to convert if the user hasn't been changed.

Finally I added usage to the docker docs in install.md

Closes #2056

@nhooyr nhooyr requested a review from code-asher September 3, 2020 19:45
code-asher
code-asher reviewed Sep 3, 2020
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment •
edited by nhooyr
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it and it's working for me. The only potential issue is that changes I make to the mounted directories don't show in the Docker container (and vice-versa). Would something like a symlink work, maybe? - resolved

@nhooyr
docker: Fix $DOCKER_USER
4e2acab 
We do not try renaming $HOME anymore as there is no good way
to do it.

We also only try to convert if the user hasn't been changed.

Finally I added usage to the docker docs in install.md

Closes #2056
code-asher
code-asher approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@nhooyr nhooyr merged commit 9fb318c into master Sep 3, 2020
@nhooyr nhooyr deleted the docker-e56a branch September 3, 2020 22:38
@nhooyr nhooyr mentioned this pull request Oct 6, 2020
Closed
@avaidyam avaidyam mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nhooyr @code-asher