Skip to content

Conversation

rowansmithau
Copy link
Contributor

Per Slack discussion this PR allows folks who deploy to Kubernetes to make use of the --verbose and --sign runtime parameters so they don't have to manually edit the template pre/post deployment.

Both are opt in and disabled by default in order to not change existing behaviour.

➜  helm git:(feat/helm_expose_sign_and_logging_params)  helm template -n code-marketplace --create-namespace code-marketplace . --set verboseLogging=true --set extensionSigning=true
....
# Source: code-marketplace/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
....
          args:
            - --address
            - "0.0.0.0:80"
            - --extensions-dir
            - /extensions
            - --verbose
            - --sign
          volumeMounts:
➜  helm git:(feat/helm_expose_sign_and_logging_params)  helm template -n code-marketplace --create-namespace code-marketplace .
....
          args:
            - --address
            - "0.0.0.0:80"
            - --extensions-dir
            - /extensions
          volumeMounts:

@rowansmithau rowansmithau self-assigned this Sep 8, 2025
@rowansmithau rowansmithau added the enhancement New feature or request label Sep 8, 2025
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@code-asher code-asher merged commit 1c3a19e into main Sep 8, 2025
2 checks passed
@code-asher code-asher deleted the feat/helm_expose_sign_and_logging_params branch September 8, 2025 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants