[CY-5242] [Bug]install-binary.sh returning 2 URLs for OS=linux breaking 'helm plugin install' on linux

[johnphilipscs]

When this line is executed with OS=linux, a string containing 2 URLs are returned and then the download curl fails due to malformed URL:

helm-ssm/install-binary.sh

Line 62 in 7f64ef2

DOWNLOAD_URL=$(curl -s $latest_url | grep $OS | awk '/"browser_download_url":/{gsub( /[,"]/,"", $2); print $2}')

Here is what is returned:
https://github.com/codacy/helm-ssm/releases/download/3.1.9/helm-ssm-linux-arm.tgz https://github.com/codacy/helm-ssm/releases/download/3.1.9/helm-ssm-linux.tgz

Due to this helm plugin install always fails if run on OS that return linux to this line:

helm-ssm/install-binary.sh

Line 32 in 7f64ef2

OS=$(echo $(uname)|tr '[:upper:]' '[:lower:]')

Seems have been result of arm addition causing 2 entries in releases to match grep for 'linux'

[github-actions]

Internal ticket created : CY-5242

we are facing the same issue hope that there is a fix soon

[romeritoCL]

Fast fix: Kahzerx@ead09b9

[romeritoCL]

@johnphilipscs and @aelnaggar i've fixed both issues on this PR: https://github.com/codacy/helm-ssm/pull/52/files

hope we have it merged soon.

[gedd-shelf]

Bumping this issue and hoping to get the PR merged soon!

[vdog]

helm plugin add --version 3.1.8 https://github.com/codacy/helm-ssm

doesn't work either :(

here's a workaround i used for my .gitlab-ci.yaml after making my own helm-ssm-linux.tgz and committing it to my chart repo:

#  - helm plugin add https://github.com/codacy/helm-ssm
    - export HELM_PLUGIN_DIR=$(helm env | grep HELM_PLUGINS | cut -d\" -f2)/helm-ssm
    - mkdir -p $HELM_PLUGIN_DIR
    - mkdir -p _dist/helm-ssm
    - tar -xf helm-ssm-linux.tgz -C _dist/helm-ssm
    - cp -r _dist/helm-ssm/* $HELM_PLUGIN_DIR

which i cribbed from make install

[onlythere]

There is no need to make own archive, we can download it right from github

      - wget --quiet https://github.com/codacy/helm-ssm/releases/download/3.1.9/helm-ssm-linux.tgz
      - export HELM_PLUGIN_DIR=$(helm env | grep HELM_PLUGINS | cut -d\" -f2)/helm-ssm
      - mkdir -p $HELM_PLUGIN_DIR
      - mkdir -p _dist/helm-ssm
      - tar -xf helm-ssm-linux.tgz -C _dist/helm-ssm
      - cp -r _dist/helm-ssm/* $HELM_PLUGIN_DIR
      - rm -rf _dist/
      - helm ssm -h

[gaspo53]

Same happening here, using ROK8s scripts image from Fairwinds (Linux): https://rok8s-scripts.docs.fairwinds.com/ci-images/

bash-5.1# helm plugin add https://github.com/codacy/helm-ssm --debug [debug] vcs_installer.go:159: cloning https://github.com/codacy/helm-ssm to /root/.cache/helm/plugins/https-github.com-codacy-helm-ssm [debug] vcs_installer.go:91: copying /root/.cache/helm/plugins/https-github.com-codacy-helm-ssm to /root/.local/share/helm/plugins/helm-ssm plugin_install.go:82: [debug] loading plugin from /root/.local/share/helm/plugins/helm-ssm plugin.go:60: [debug] running install hook: /bin/sh -c $HELM_PLUGIN_DIR/install-binary.sh Downloading https://github.com/codacy/helm-ssm/releases/download/3.1.9/helm-ssm-linux-arm.tgz https://github.com/codacy/helm-ssm/releases/download/3.1.9/helm-ssm-linux.tgz curl: (3) URL using bad/illegal format or missing URL Failed to install helm-ssm For support, go to https://github.com/codacy/helm-ssm. Error: plugin install hook for "ssm" exited with error helm.go:88: [debug] plugin install hook for "ssm" exited with error main.runHook helm.sh/helm/v3/cmd/helm/plugin.go:67 main.(*pluginInstallOptions).run helm.sh/helm/v3/cmd/helm/plugin_install.go:88 main.newPluginInstallCmd.func3 helm.sh/helm/v3/cmd/helm/plugin_install.go:59 github.com/spf13/cobra.(*Command).execute github.com/spf13/cobra@v1.1.3/command.go:852 github.com/spf13/cobra.(*Command).ExecuteC github.com/spf13/cobra@v1.1.3/command.go:960 github.com/spf13/cobra.(*Command).Execute github.com/spf13/cobra@v1.1.3/command.go:897 main.main helm.sh/helm/v3/cmd/helm/helm.go:87 runtime.main runtime/proc.go:225 runtime.goexit runtime/asm_amd64.s:1371

[SamDrobakha]

Same here, got 2 links on a linux box during docker file creation.

[CallMeLeopoldo]

Raised and merge for this issue (#76) where we only use the default linux amd binary.