Nette extension: do not autowire template helper

[lookyman]

..also previous setInject was pointless.

[florianeckerstorfer]

I have no experience with Nette what-so-ever, would you mind to explain this change to me and does it break existing usage of the service?

[lookyman]

Technically yes, it is a BC break. Previously, the template helper was registered as an autowireable service in DI container, which meant you could autowire it by it's class name (like, in typehint) into your services if you wanted to. Now, if you want to achieve the same result, you have to pass it manually in config by it's service name (@slugify.helper).

However, the only sane place in which you want to have a template helper is Latte engine (which creates templates for you), and the extension does that already. If you want to have a Slugify service anywhere else, you should autowire SlugifyInterface instead. This is the best practice and all other similar helpers in Nette or other extensions behave this way. It was also my original intention when I wrote this extension, so the current state is actually a mistake.

The setInject(false) thing was pointless because it turns off some functionality for this service that it doesn't have.

[florianeckerstorfer]

Thanks for taking the time explaining this. I will just trust you on this.