Simplify default regular expression#217
Merged
florianeckerstorfer merged 1 commit intococur:masterfrom Oct 24, 2018
julienfalque:simplify-default-regexp
Merged
Simplify default regular expression#217florianeckerstorfer merged 1 commit intococur:masterfrom julienfalque:simplify-default-regexp
florianeckerstorfer merged 1 commit intococur:masterfrom
julienfalque:simplify-default-regexp
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-is already matched by[^A-Za-z0-9]so the regular expression can be simplified.This does not require a new minor release and could be included in a patch one but I don't know whether lower branches are still maintained so I'm targetting master for now. Please let me know if I should rebase onto another branch.