[Spec 0060] Dashboard modularization#112
Merged
waleedkadous merged 3 commits intomainfrom Dec 16, 2025
Merged
Conversation
- Extract CSS into 9 files: variables, layout, tabs, statusbar, dialogs, activity, projects, files, utilities - Extract JS into 8 files: state, utils, tabs, dialogs, projects, files, activity, main - Create modular index.html with proper dependency ordering - Add server routes for /dashboard/css/* and /dashboard/js/* - Add /api/hot-reload endpoint for development hot reloading - Add client-side hot reload: CSS instant reload, JS with state preservation - Update clipboard tests for modular structure
Contributor
Author
Architect Integration Review (3-Way)Gemini: APPROVE | Codex: COMMENT | Claude: REQUEST_CHANGES Critical IssueHot reload polling is always active - The client polls Fix required: Gate hot reload behind a query param or environment check: // Only enable hot reload in development
const isDev = window.location.search.includes('dev=1') || window.location.hostname === 'localhost';
if (isDev) {
setupHotReload();
}Minor Issues (can defer)
Manual TestingPlease check off the manual testing items in the PR description before merge. 🏗️ Architect integration review |
Hot reload polling now only activates when: - Hostname is localhost or 127.0.0.1 - Or query param ?dev=1 is present This prevents unnecessary polling in production environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dashboard-split.htmlinto clean, maintainable structureChanges
/dashboard/css/*and/dashboard/js/*server routes with path traversal protection/api/hot-reloadendpoint for development hot reloadingTest plan
Files
packages/codev/templates/dashboard/directory structuredashboard-server.ts(routes, hot-reload)clipboard.test.ts(updated for modular structure)