Skip to content

Conversation

@ovindu-a
Copy link
Contributor

@ovindu-a ovindu-a commented Oct 1, 2024

Description

I have added jsdoc comments that include a description, example and linked the docs page.

Issue Ticket Number

Fixes #144 (add jsdoc descriptions to the helpers)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 44c3bad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-cloudinary Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 1, 2024

@ovindu-a is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only some minor tweaks then LGTM! Could you add a changeset, for this. it can be marked as a minor and have a message like feat: add jsdoc descriptions to the helpers

https://github.com/cloudinary-community/svelte-cloudinary/blob/main/CONTRIBUTING.md#changesets

@vercel
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-cloudinary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 0:37am

@ghostdevv
Copy link
Collaborator

Looks like there are some lint errors, you can run pnpm format to fix those

ovindu-a and others added 2 commits October 2, 2024 16:03
Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>
Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>
Copy link
Collaborator

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, one more thing 😅 (+ the pnpm format)

@ovindu-a
Copy link
Contributor Author

ovindu-a commented Oct 2, 2024

@ghostdevv , shall I make a new pull request with the changes?

@ghostdevv
Copy link
Collaborator

@ovindu-a you can update this one!

@ovindu-a
Copy link
Contributor Author

ovindu-a commented Oct 2, 2024

@ghostdevv I am having an issue when adding the changeset.

error Error: Failed to find where HEAD diverged from main. Does main exist

@ghostdevv
Copy link
Collaborator

ghostdevv commented Oct 2, 2024

hmm, looks like you're not on your branch issue-144, try running

git reset origin/main --hard
git checkout issue-144
git pull

@ovindu-a
Copy link
Contributor Author

ovindu-a commented Oct 2, 2024

Thank you @ghostdevv, I have made the new commit

@ghostdevv ghostdevv changed the title Changes for issue "add jsdoc descriptions to the helpers #144: feat: add jsdoc descriptions to the helpers Oct 2, 2024
Copy link
Collaborator

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, ty!

@ghostdevv ghostdevv merged commit 10c6ac4 into cloudinary-community:main Oct 2, 2024
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
@colbyfayock
Copy link
Contributor

hey @ovindu-a thanks for the contribution! This merged PR is eligible for some free swag from Cloudinary.

Please send an email over to hacktoberfest@cloudinary.com with your name, GitHub username, and link to the PR where I'll provide you with the next steps for claiming your swag.

Happy Hacktoberfest!

@ovindu-a
Copy link
Contributor Author

ovindu-a commented Oct 2, 2024

Woahh that's cool @colbyfayock, I just sent you an email. A special thanks to @ghostdevv for guiding me through the process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add jsdoc descriptions to the helpers

3 participants