-
Notifications
You must be signed in to change notification settings - Fork 23
feat: add jsdoc descriptions to the helpers #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 44c3bad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@ovindu-a is attempting to deploy a commit to the Cloudinary DevX Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only some minor tweaks then LGTM! Could you add a changeset, for this. it can be marked as a minor and have a message like feat: add jsdoc descriptions to the helpers
https://github.com/cloudinary-community/svelte-cloudinary/blob/main/CONTRIBUTING.md#changesets
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks like there are some lint errors, you can run |
Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>
Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, one more thing 😅 (+ the pnpm format)
|
@ghostdevv , shall I make a new pull request with the changes? |
|
@ovindu-a you can update this one! |
|
@ghostdevv I am having an issue when adding the changeset.
|
|
hmm, looks like you're not on your branch |
|
Thank you @ghostdevv, I have made the new commit |
ghostdevv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, ty!
|
hey @ovindu-a thanks for the contribution! This merged PR is eligible for some free swag from Cloudinary. Please send an email over to hacktoberfest@cloudinary.com with your name, GitHub username, and link to the PR where I'll provide you with the next steps for claiming your swag. Happy Hacktoberfest! |
|
Woahh that's cool @colbyfayock, I just sent you an email. A special thanks to @ghostdevv for guiding me through the process! |
Description
I have added jsdoc comments that include a description, example and linked the docs page.
Issue Ticket Number
Fixes #144 (add jsdoc descriptions to the helpers)
Type of change
Checklist