fix: Improve search error handling and display failed searches properly #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add specific exception handling for connection, timeout, and HTTP errors in PubMedClient - Add is_failed and is_successful properties to SearchResult model - Enhance Results page to properly display failed searches with error details - Add Failed Searches section with detailed error information - Provide CSV download functionality for failed searches to enable retry - Fix issue where SSL connection errors appeared as successful searches with 0 results Closes #34 (partial implementation - provides foundation for retry functionality) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
ClientConnectionError,ClientTimeout, andClientResponseErroris_failedandis_successfulproperties for cleaner error checkingProblem Solved
Previously, when SSL connection errors occurred (like
[SSL: APPLICATION_DATA_AFTER_CLOSE_NOTIFY]), searches would appear as "successful" with 0 results instead of being properly marked as failed. This was confusing for users who couldn't distinguish between legitimate 0 results vs connection failures.Test Plan
Related Issues
🤖 Generated with Claude Code