fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…#2899
Merged
nikosdouvlis merged 1 commit intomainfrom Mar 1, 2024
Merged
fix(nextjs,clerk-js): Make useAwaitableNavigate handle navigations be…#2899nikosdouvlis merged 1 commit intomainfrom
nikosdouvlis merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 816cd12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
!snapshot |
Collaborator
|
Hey @nikosdouvlis - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/backend@1.0.1-snapshot.v009a4cc --save-exact
npm i @clerk/chrome-extension@1.0.1-snapshot.v009a4cc --save-exact
npm i @clerk/clerk-js@5.0.1-snapshot.v009a4cc --save-exact
npm i @clerk/clerk-expo@1.0.1-snapshot.v009a4cc --save-exact
npm i @clerk/fastify@1.0.1-snapshot.v009a4cc --save-exact
npm i gatsby-plugin-clerk@5.0.1-snapshot.v009a4cc --save-exact
npm i @clerk/localizations@2.0.1-snapshot.v009a4cc --save-exact
npm i @clerk/nextjs@5.0.1-snapshot.v009a4cc --save-exact
npm i @clerk/clerk-react@5.0.1-snapshot.v009a4cc --save-exact
npm i @clerk/remix@4.0.1-snapshot.v009a4cc --save-exact
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v009a4cc --save-exact
npm i @clerk/shared@2.0.1-snapshot.v009a4cc --save-exact
npm i @clerk/themes@2.0.1-snapshot.v009a4cc --save-exact
npm i @clerk/types@4.0.1-snapshot.v009a4cc --save-exact |
nikosdouvlis
force-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
009a4cc to
ee06378
Compare
…tween pages reliably We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
nikosdouvlis
force-pushed
the
nikos/v5-fix-awaitable-navigate
branch
from
ee06378 to
816cd12
Compare
jacekradko
added a commit
that referenced
this pull request
Mar 5, 2026
…lution Add unit and integration tests to validate that removing usePathname from useInternalNavFun's effect deps (#7989) doesn't regress the navigation promise flushing behavior originally fixed in #2899. Unit tests: - Single navigation promise resolves via isPending alone - Pre-existing window buffer flushed on mount (ClerkProvider remount) - Pending promises flushed on unmount (ClerkProvider unmount) - Internal navigations use history pushState instead of router Integration tests (cache-components / cacheComponents: true): - Sign out completes without hanging (exercises full setActive → navigate → routerPush → useInternalNavFun chain) - Protected route redirects correctly after sign out (validates cache invalidation + navigation)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tween pages reliably
We need to use window to store the reference to the buffer, as ClerkProvider might be unmounted and remounted during navigations. If we use a ref, it will be reset when ClerkProvider is unmounted
v5 port of #2889
Description
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change